linux-kernel - Re: [PATCH RFC v2 2/2] irqchip: irq-ti-sci-inta: Add direct mapped interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c42185ee1b224fd7814b6e336a3fc3f5@kernel.org>
Date:   Sat, 08 Apr 2023 12:36:38 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     "Raghavendra, Vignesh" <vigneshr@...com>
Cc:     Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v2 2/2] irqchip: irq-ti-sci-inta: Add direct mapped
 interrupts

On 2023-04-08 12:27, Raghavendra, Vignesh wrote:
> Hi,
> 
> On 4/8/2023 4:10 PM, Marc Zyngier wrote:
>>> +static unsigned int ti_sci_inta_direct_events_am62x[] = {
>>> +	/* CPSW etherenti DMA events */
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4627),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4635),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4643),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4651),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4659),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4667),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4675),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4683),
>>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 5651),
>>> +};
>>> +
>>> +static struct ti_sci_inta_soc_data soc_data_am62x = {
>>> +	.events_list = ti_sci_inta_direct_events_am62x,
>>> +	.events_list_size = ARRAY_SIZE(ti_sci_inta_direct_events_am62x),
>>> +};
>> I don't think these tables belong in a driver, and they are bound to
>> grow without any obvious limits.
> 
> Fair point.
> 
>> You have firmware tables that can express these things. Surely they 
>> can be put to a good use.
> 
> By firmware tables you mean device tree?

That, or any other machine-specific mean. From what I get of these
systems, they already make heavy use of some runtime firmware to get
things configured. That side could also provide setup information.

I don't mind either way, as long as we don't end-up with forever
growing in-kernel tables that are just board files in disguise.

           M.
-- 
Jazz is not dead. It just smells funny...