linux-kernel - Re: [PATCH] regulator: sm5703: Fix missing n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfcd6736-f822-fdda-a84d-4f4bb91cd653@gmail.com>
Date:   Sun, 9 Apr 2023 16:25:02 +0300
From:   Markuss Broks <markuss.broks@...il.com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: sm5703: Fix missing n_voltages for fixed
 regulators

Looks good.

Reviewed-by: Markuss Broks <markuss.broks@...il.com>

On 4/9/23 05:55, Axel Lin wrote:
> Set n_voltages = 1 for fixed regulators.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>   drivers/regulator/sm5703-regulator.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/regulator/sm5703-regulator.c b/drivers/regulator/sm5703-regulator.c
> index 38e66df378a5..702461cf075e 100644
> --- a/drivers/regulator/sm5703-regulator.c
> +++ b/drivers/regulator/sm5703-regulator.c
> @@ -42,6 +42,7 @@ static const int sm5703_buck_voltagemap[] = {
>   		.type = REGULATOR_VOLTAGE,				\
>   		.id = SM5703_USBLDO ## _id,				\
>   		.ops = &sm5703_regulator_ops_fixed,			\
> +		.n_voltages = 1,					\
>   		.fixed_uV = SM5703_USBLDO_MICROVOLT,			\
>   		.enable_reg = SM5703_REG_USBLDO12,			\
>   		.enable_mask = SM5703_REG_EN_USBLDO ##_id,		\
> @@ -56,6 +57,7 @@ static const int sm5703_buck_voltagemap[] = {
>   		.type = REGULATOR_VOLTAGE,				\
>   		.id = SM5703_VBUS,					\
>   		.ops = &sm5703_regulator_ops_fixed,			\
> +		.n_voltages = 1,					\
>   		.fixed_uV = SM5703_VBUS_MICROVOLT,			\
>   		.enable_reg = SM5703_REG_CNTL,				\
>   		.enable_mask = SM5703_OPERATION_MODE_MASK,		\