linux-kernel - Re: [PATCH v1] usb: typec: tcpm: Add kernel config to wrap around tcpm logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023041028-irritate-starless-a42f@gregkh>
Date:   Mon, 10 Apr 2023 09:45:43 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     linux@...ck-us.net, heikki.krogerus@...ux.intel.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Add kernel config to wrap around
 tcpm logs

On Mon, Apr 10, 2023 at 07:31:34AM +0000, Badhri Jagan Sridharan wrote:
> This change adds CONFIG_TCPM_LOG_WRAPAROUND which when set allows the
> logs to be wrapped around. Additionally, when set, does not clear
> the TCPM logs when dumped.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>
> ---
>  drivers/usb/typec/tcpm/Kconfig | 6 ++++++
>  drivers/usb/typec/tcpm/tcpm.c  | 9 +++++++--
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
> index e6b88ca4a4b9..4dd2b594dfc9 100644
> --- a/drivers/usb/typec/tcpm/Kconfig
> +++ b/drivers/usb/typec/tcpm/Kconfig
> @@ -18,6 +18,12 @@ config TYPEC_TCPCI
>  	help
>  	  Type-C Port Controller driver for TCPCI-compliant controller.
>  
> +config TCPM_LOG_WRAPAROUND
> +	bool "Enable TCPM log wraparound"
> +	help
> +	  When set, wraps around TCPM logs and does not clear the logs when dumped. TCPM logs by
> +	  default gets cleared when dumped and does not wraparound when full.

Kconfig help text needs to be wrapped at the properly width.

And you do not provide any hint here as to why this is not the default
option, or why someone would want this.

So, why is this not just the default operation anyway?  Why would you
ever want the logs cleared?

thanks,

greg k-h