linux-kernel - Re: [PATCH] tools: memory-model: Rename litmus test to avoid confusion with similar-named test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 10:31:50 +0900
From:   Akira Yokosawa <akiyks@...il.com>
To:     "Joel Fernandes (Google)" <joel@...lfernandes.org>,
        "Paul E. McKenney" <paulmck@...nel.org>
Cc:     linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alan Stern <stern@...land.harvard.edu>,
        Andrea Parri <parri.andrea@...il.com>,
        Will Deacon <will@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Boqun Feng <boqun.feng@...il.com>,
        Nicholas Piggin <npiggin@...il.com>,
        David Howells <dhowells@...hat.com>,
        Jade Alglave <j.alglave@....ac.uk>,
        Luc Maranget <luc.maranget@...ia.fr>,
        Daniel Lustig <dlustig@...dia.com>,
        Akira Yokosawa <akiyks@...il.com>
Subject: Re: [PATCH] tools: memory-model: Rename litmus test to avoid
 confusion with similar-named test

Hi Joel,

On Sun,  9 Apr 2023 04:48:22 +0000, Joel Fernandes (Google) wrote:
> In order to differentiate the test
> Z6.0+pooncelock+poonceLock+pombonce.litmus from another test that only
> differs by a capital L, the following file has been renamed:
> 
> renamed: litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus ->
> litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
> 
> This change should help avoid confusion between the two tests.
> 
> Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
> ---
>  ...mbonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} (100%)
> 
> diff --git a/tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus b/tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
> similarity index 100%
> rename from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
> rename to tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus

I must say simply changing the file name is only part of the job.
You need to update comments/docs as well.

There are 4 hits after this patch is applied:

$ find . -type f -exec grep -nH --null -F -e Z6.0+pooncelock+poonceLock \{\} +
./tools/memory-model/Documentation/locking.txt187:	/* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/Documentation/recipes.txt162:	/* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus1:C Z6.0+pooncelock+poonceLock+pombonce
./tools/memory-model/litmus-tests/README152:Z6.0+pooncelock+poonceLock+pombonce.litmus

        Thanks, Akira