linux-kernel - Re: [PATCH] maple_tree: Use correct variable type in sizeof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1ea2c08-8e88-e04f-417b-4cf0daa417b1@bytedance.com>
Date:   Mon, 10 Apr 2023 18:09:27 +0800
From:   Peng Zhang <zhangpeng.00@...edance.com>
To:     Gang Li <ligang.bdlg@...edance.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org,
        David Binderman <dcb314@...mail.com>
Subject: Re: [PATCH] maple_tree: Use correct variable type in sizeof


在 2023/4/10 17:46, Gang Li 写道:
> On 2023/4/10 17:14, Peng Zhang wrote:
>> The original code is:
>>     memset(pivs + tmp, 0, sizeof(unsigned long *) * (max_p - tmp));
>>
>> The type of variable pointed to by pivs is unsigned long, but the type
>> used in sizeof is a pointer type. Change it to unsigned long.
>>
>
> Maybe add a fix tag?
>
> Fixes: 54a611b60590 ("Maple Tree: add new data structure")

Maybe sizeof(void *) is equal to sizeof(unsigned long)
in most architectures, so I don't know if it counts as a fix.

Thanks.

>
>> Suggested-by: David Binderman <dcb314@...mail.com>
>> Signed-off-by: Peng Zhang <zhangpeng.00@...edance.com>
>> ---
>>   lib/maple_tree.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
>> index 88c44f6d6cee..b06fc5f19b31 100644
>> --- a/lib/maple_tree.c
>> +++ b/lib/maple_tree.c
>> @@ -3255,7 +3255,7 @@ static inline void mas_destroy_rebalance(struct 
>> ma_state *mas, unsigned char end
>>             if (tmp < max_p)
>>               memset(pivs + tmp, 0,
>> -                   sizeof(unsigned long *) * (max_p - tmp));
>> +                   sizeof(unsigned long) * (max_p - tmp));
>>             if (tmp < mt_slots[mt])
>>               memset(slots + tmp, 0, sizeof(void *) * (max_s - tmp));
>