linux-kernel - RE: [PATCH] cxgbit: check skb dequeue result in cxgbit_send_tx_flowc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN9PR12MB5324AEFFA45F46CA998CB450BC959@BN9PR12MB5324.namprd12.prod.outlook.com>
Date:   Mon, 10 Apr 2023 11:49:29 +0000
From:   Varun Prakash <varun@...lsio.com>
To:     Denis Plotnikov <den-plotnikov@...dex-team.ru>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "nab@...ux-iscsi.org" <nab@...ux-iscsi.org>
Subject: RE: [PATCH] cxgbit: check skb dequeue result in
 cxgbit_send_tx_flowc_wr()


>Skb dequeuing may end up with returning NULL if a queue is empty,
>which, in turn, may end up with further null pointer dereference.
>
>Fix it by checking the return value of skb dequeuing end returning
>before the pointer dereference.

skbs in csk->skbq are preallocated for critical events in cxgbit_alloc_csk_skb(),
so there is no need to check for NULL.