linux-kernel - Re: [PATCH] scsi: target: cxgbit: check skb dequeue result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b5cfdc4-817e-30b5-7295-5bca9c31a0b7@yandex-team.ru>
Date:   Mon, 10 Apr 2023 16:04:31 +0300
From:   Denis Plotnikov <den-plotnikov@...dex-team.ru>
To:     Varun Prakash <varun@...lsio.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "nab@...ux-iscsi.org" <nab@...ux-iscsi.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: [PATCH] scsi: target: cxgbit: check skb dequeue result


On 10.04.2023 14:45, Varun Prakash wrote:
>> On a couple of abort packet paths skb dequeuing may end up with
>> returning NULL, which, in turn, may end up with further null
>> pointer dereference.
>>
>> Fix it by checking the return value of skb dequeuing.
> skbs in csk->skbq are preallocated for critical events in cxgbit_alloc_csk_skb(),
> so there is no need to check for NULL.
Ok, thanks for the reply