linux-kernel - Re: [PATCH for-next 1/3] RDMA/rtrs: Remove duplicate cq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28516715-ed06-6ac2-d65c-551da18997a9@linux.dev>
Date:   Mon, 10 Apr 2023 21:09:52 +0800
From:   Guoqing Jiang <guoqing.jiang@...ux.dev>
To:     Li Zhijian <lizhijian@...itsu.com>, haris.iqbal@...os.com,
        jinpu.wang@...os.com, jgg@...pe.ca, leon@...nel.org,
        linux-rdma@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next 1/3] RDMA/rtrs: Remove duplicate cq_num
 assignment



On 4/10/23 14:43, Li Zhijian wrote:
> line 1701 and 1713 are duplicate:
>> 1701         cq_num = max_send_wr + max_recv_wr;
>   1702         /* alloc iu to recv new rkey reply when server reports flags set */
>   1703         if (clt_path->flags & RTRS_MSG_NEW_RKEY_F || con->c.cid == 0) {
>   1704                 con->rsp_ius = rtrs_iu_alloc(cq_num, sizeof(*rsp),
>   1705                                               GFP_KERNEL,
>   1706                                               clt_path->s.dev->ib_dev,
>   1707                                               DMA_FROM_DEVICE,
>   1708                                               rtrs_clt_rdma_done);
>   1709                 if (!con->rsp_ius)
>   1710                         return -ENOMEM;
>   1711                 con->queue_num = cq_num;
>   1712         }
>> 1713         cq_num = max_send_wr + max_recv_wr;
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
>   drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index 80abf45a197a..c2065fc33a56 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -1710,7 +1710,6 @@ static int create_con_cq_qp(struct rtrs_clt_con *con)
>   			return -ENOMEM;
>   		con->queue_num = cq_num;
>   	}
> -	cq_num = max_send_wr + max_recv_wr;
>   	cq_vector = con->cpu % clt_path->s.dev->ib_dev->num_comp_vectors;
>   	if (con->c.cid >= clt_path->s.irq_con_num)
>   		err = rtrs_cq_qp_create(&clt_path->s, &con->c, max_send_sge,

Acked-by: Guoqing Jiang <guoqing.jiang@...ux.dev>

Thanks,
Guoqing