linux-kernel - Re: [PATCH v6 0/8] Add multiport support for DWC3 controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 17:24:21 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc:     Krishna Kurapati <quic_kriskura@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "quic_pkondeti@...cinc.com" <quic_pkondeti@...cinc.com>,
        "quic_ppratap@...cinc.com" <quic_ppratap@...cinc.com>,
        "quic_wcheng@...cinc.com" <quic_wcheng@...cinc.com>,
        "quic_jackp@...cinc.com" <quic_jackp@...cinc.com>,
        "quic_harshq@...cinc.com" <quic_harshq@...cinc.com>,
        "ahalaney@...hat.com" <ahalaney@...hat.com>,
        "quic_shazhuss@...cinc.com" <quic_shazhuss@...cinc.com>
Subject: Re: [PATCH v6 0/8] Add multiport support for DWC3 controllers

On 09/04/2023 01:09, Thinh Nguyen wrote:
> On Sat, Apr 08, 2023, Krzysztof Kozlowski wrote:
>> On 08/04/2023 03:42, Thinh Nguyen wrote:
>>>> Krishna Kurapati (8):
>>>>   dt-bindings: usb: Add bindings for multiport properties on DWC3
>>>>     controller
>>>>   usb: dwc3: core: Access XHCI address space temporarily to read port
>>>>     info
>>>>   usb: dwc3: core: Skip setting event buffers for host only controllers
>>>>   usb: dwc3: core: Refactor PHY logic to support Multiport Controller
>>>>   usb: dwc3: qcom: Add multiport controller support for qcom wrapper
>>>>   arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280
>>>>   arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB
>>>>     ports
>>>>   arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb
>>>>     controller
>>>>
>>>>  .../devicetree/bindings/usb/snps,dwc3.yaml    |  13 +-
>>>>  arch/arm64/boot/dts/qcom/sa8295p-adp.dts      |  47 +++
>>>>  arch/arm64/boot/dts/qcom/sa8540p-ride.dts     |  22 ++
>>>>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi        |  58 +++
>>>>  drivers/usb/dwc3/core.c                       | 373 ++++++++++++++----
>>>>  drivers/usb/dwc3/core.h                       |  71 +++-
>>>>  drivers/usb/dwc3/drd.c                        |  13 +-
>>>>  drivers/usb/dwc3/dwc3-qcom.c                  |  28 +-
>>>>  8 files changed, 523 insertions(+), 102 deletions(-)
>>>>
>>>> -- 
>>>> 2.40.0
>>>>
>>>
>>> Please check if your patches and mailing client. Looks like they are
>>> corrupted.
>>
>> All patches look from patch-syntax and apply fine. What is exactly
>> corrupted?
>>
> 
> Hm... perhaps it's an encoding issue from my mail client then. I get
> this from my automated checks:
> 
> <snip>
> 
> ERROR: spaces required around that '=' (ctx:WxV)
> #429: FILE: drivers/usb/dwc3/core.h:1697:
> +		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=
>  		                                                               ^
> 
> ERROR: spaces required around that '=' (ctx:VxV)
> #429: FILE: drivers/usb/dwc3/core.h:1697:
> +		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=
>  		                                                                  ^
> 
> ERROR: spaces required around that '=' (ctx:VxE)
> #429: FILE: drivers/usb/dwc3/core.h:1697:
> +		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=
>  		                                                                        ^
> 
> ERROR: do not use assignment in if condition
> #429: FILE: drivers/usb/dwc3/core.h:1697:
> +		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=
> 
> ERROR: spaces required around that '=' (ctx:WxV)
> #433: FILE: drivers/usb/dwc3/core.h:1700:
> +		next =3D XHCI_EXT_CAPS_NEXT(val);
>  		     ^
> 
> ERROR: spaces required around that '+=' (ctx:WxV)
> #434: FILE: drivers/usb/dwc3/core.h:1701:
> +		offset +=3D next << 2;
> 
> </snip>
> 
> 
> The "=" gets encoded to =3D, which is strange. It never happened before.
> I need to check my mail client. Sorry for the noise.

I don't see it, but I did not check each patch thoroughly. I also do not
know to which patch do you refer to. It is the easiest to reply inline
under the block which is corrupted. If you suspect you email client is
the cause, just check on lore.

Best regards,
Krzysztof