lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 10 Apr 2023 15:52:47 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Cem Kaya <cemkaya.boun@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x
 so that internal DMIC works.

[Public]

> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> mach.c
> index a428e17f0325..e044d811496e 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
>  };
> 
>  static const struct dmi_system_id yc_acp_quirk_table[] = {
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15
> 5525"),
> +		}
> +	},
>  	{
>  		.driver_data = &acp6x_card,
>  		.matches = {
> --
> 2.40.0

Hi,

Thanks for sending this up, but you'll need to add a few things:

1) You need to add a commit message explaining the why
2) You're missing a SoB tag (IE Signed-off-by: Foo Bar <foo@....com>)
3) As this came from a kernel Bugzilla originally, suggest you to add Link tag:

Link: https://foo.bar.com/url

4) When you resubmit, please change PATCH to "PATCH v2"

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ