linux-kernel - Re: [PATCH v3] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rez4rpp.wl-tiwai@suse.de>
Date:   Mon, 10 Apr 2023 18:39:14 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Cem Kaya <cemkaya.boun@...il.com>
Cc:     "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "mario.limonciello@....com" <mario.limonciello@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

On Mon, 10 Apr 2023 18:03:36 +0200,
Cem Kaya wrote:
> 
> 
> From 972ad712cfda9453a720b73c645601db23d708c6 Mon Sep 17 00:00:00 2001
> From: Cem Kaya <cemkaya.boun@...il.com>
> Date: Sat, 8 Apr 2023 16:20:42 +0200
> Subject: [PATCH v3] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x
> so
>  that internal DMIC works.
> Signed-off-by: Cem Kaya <cemkaya.boun@...il.com>
> Commit: Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that
> internal mic works.
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217155

Looks better, but still a few things to be correctly formatted.

The subject line needs the proper prefix, depending on the subsystem.
In your case, put "ASoC: amd:", for example.  Also, the subject line
should be concise.

The patch description is no such a tag like "Commit:", but it should
be filled in the commit log.  This can be as long as you like, but put
the line breaks appropriately.

The Link and Signed-off-by tags follow after the patch description
with a blank line.

In your case, it'd be worth to put Cc-to-stable, too.

So, it should be like:

-- 8< --
From: Cem Kaya <cemkaya.boun@...il.com>
Subject: [PATCH v3] ASoC: amd: Add Dell G15 5525 to quirks list for internal DMIC

Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that
internal mic works.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217155
Cc: <stable@...r.kernel.org>
Signed-off-by: Cem Kaya <cemkaya.boun@...il.com>
-- 8< --

..., and get the right maintainer via scripts/get_maintainer.pl, put
them to Cc.

For details, please read
Documentation/process/submitting-patches.rst.

*HOWEVER*: the most serious problem is in this patch submission is...

> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
>  };
>  
>  static const struct dmi_system_id yc_acp_quirk_table[] = {
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5525"),
> + }
> + },

... somehow the patch itself became broken (while v2 patch looked
OK).  Please verify how this got broken and try to submit correctly at
the next time.

thanks,

Takashi