linux-kernel - Re: [PATCH v1 1/4] dt-bindings: mfd: x-powers,axp152: Document the AXP15060 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffe813e4-e3ad-3dff-b8e5-42b0f82faed3@linaro.org>
Date:   Mon, 10 Apr 2023 19:27:56 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shengyu Qu <wiagn233@...look.com>, lee@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        wens@...e.org, lgirdwood@...il.com, broonie@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: mfd: x-powers,axp152: Document the
 AXP15060 variant

On 07/04/2023 16:18, Shengyu Qu wrote:
> The X-Powers AXP15060 is a PMIC seen on Starfive Visionfive 2 board. Add
> relative compatible item and CPUSLDO support for it.
> 
> Signed-off-by: Shengyu Qu <wiagn233@...look.com>
> ---
>  Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 3 ++-

I received cover letter disattached from rest of patchset and everything
duplicate. Please check your process of sending patches.

>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> index b7a8747d5fa0..e150a8bf040a 100644
> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> @@ -92,6 +92,7 @@ properties:
>            - x-powers,axp806
>            - x-powers,axp809
>            - x-powers,axp813
> +          - x-powers,axp15060

So you have chosen order by absolute number, not alphabetically. That's
fine, but keep it for the future entries as well. :)



>        - items:
>            - const: x-powers,axp228
>            - const: x-powers,axp221
> @@ -260,7 +261,7 @@ properties:
>            Defines the work frequency of DC-DC in kHz.
>  
>      patternProperties:
> -      "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|drivevbus|dc5ldo)$":
> +      "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|cpusldo|(dc1)?sw|rtc(_|-)ldo|drivevbus|dc5ldo)$":

It seems fixed strings are at the end of entire pattern, so "cpusldo"
should be before "drivevbus".



Best regards,
Krzysztof