[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANiq72=wqAJeqCdwDr8yXh29B_70dc51+auMmnWAahOz+f8p0w@mail.gmail.com>
Date: Mon, 10 Apr 2023 22:37:05 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Martin Rodriguez Reboredo <yakoyoku@...il.com>
Cc: linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>
Subject: Re: [PATCH] scripts: read cfgs from Makefile for rust-analyzer
On Thu, Feb 23, 2023 at 3:59 AM Martin Rodriguez Reboredo
<yakoyoku@...il.com> wrote:
>
> Both `core` and `alloc` had their `cfgs` missing in `rust-project.json`,
> to remedy this `generate_rust_analyzer.py` scans the Makefile from
> inside the `rust` directory for them to be added to a dictionary that
> each key corresponds to a crate and each value, to an array of `cfgs`.
We should pass the values to the script instead, rather than relying
on how our `Makefile` is written, even if we control it.
Cheers,
Miguel
Powered by blists - more mailing lists