linux-kernel - Re: [PATCH] EDAC/mce_amd: Decode Cache Level "L0" Error Code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9549e422-e5b2-ccf6-3c8d-ac61436e7fa6@amd.com>
Date:   Mon, 10 Apr 2023 16:53:50 -0400
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     yazen.ghannam@....com, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, avadhut.naik@....com
Subject: Re: [PATCH] EDAC/mce_amd: Decode Cache Level "L0" Error Code

On 4/10/23 16:47, Borislav Petkov wrote:
> On Mon, Apr 10, 2023 at 03:33:57PM -0500, Yazen Ghannam wrote:
>> The "L0" cache level is listed as "reserved" in legacy documentation.
>> This has now been defined as "Core" in current documentation for
>> Zen-based systems.
>>
>> Update the cache level strings to include this new definition.
>>
>> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
>> ---
>>  drivers/edac/mce_amd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
>> index cc5c63feb26a..1d1b9da3b9bd 100644
>> --- a/drivers/edac/mce_amd.c
>> +++ b/drivers/edac/mce_amd.c
>> @@ -37,7 +37,7 @@ EXPORT_SYMBOL_GPL(amd_unregister_ecc_decoder);
>>  static const char * const tt_msgs[] = { "INSN", "DATA", "GEN", "RESV" };
>>  
>>  /* cache level */
>> -static const char * const ll_msgs[] = { "RESV", "L1", "L2", "L3/GEN" };
>> +static const char * const ll_msgs[] = { "CORE", "L1", "L2", "L3/GEN" };
> 
> Still used on legacy machines. I thought we agreed we'll move all the
> decoding to luserspace, for newer Zens...
> 

I was thinking about that for the Extended Error Code descriptions. But good
point, please disregard this patch.

Thanks,
Yazen