linux-kernel - Re: [PATCH v2] ARM: dts: meson8b: correct uart_B and uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 23:14:19 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     hfdevel@....net
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        neil.armstrong@...aro.org, khilman@...libre.com,
        jbrunet@...libre.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: dts: meson8b: correct uart_B and uart_C clock references

On Fri, Apr 7, 2023 at 4:36 PM <hfdevel@....net> wrote:
>
> With the current device tree for meson8b, uarts B (e.g. available on pins
> 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they
> are relying on incorrect clocks. Change the references of pclk to the
> correct CLKID, to allow use of the two uarts.
>
> Fixes: 3375aa77135f ("ARM: dts: meson8b: Fix the UART device-tree schema validation")
Cc: stable@...r.kernel.org

> Signed-off-by: Hans-Frieder Vogt <hfdevel@....net>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

PS: the author of this change seems to be just your email address, no
name attached.
I'm not sure if Neil can fix this when applying the patch. Generally
the rule is: patch author and signed-off-by line should be equal.

And finally: thanks again for spotting and fixing this!


Best regards,
Martin