linux-kernel - Re: [PATCH v2 0/6] Refactor definitions out of perf.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 19:22:36 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        John Garry <john.g.garry@...cle.com>,
        Will Deacon <will@...nel.org>,
        James Clark <james.clark@....com>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Raul Silvera <rsilvera@...gle.com>,
        Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Florian Fischer <florian.fischer@...q.space>,
        Rob Herring <robh@...nel.org>,
        Xing Zhengjun <zhengjun.xing@...ux.intel.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Chengdong Li <chengdongli@...cent.com>,
        Denis Nikitin <denik@...omium.org>,
        Martin Liška <mliska@...e.cz>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org
Subject: Re: [PATCH v2 0/6] Refactor definitions out of perf.h

Em Mon, Apr 10, 2023 at 09:25:05AM -0700, Ian Rogers escreveu:
> Move definitions and declarations for greater consistency.
> 
> The original motivation was, when fuzzing something like parse-events,
> having the main function in perf.c alongside global variables like
> input_name means that input_name must be redeclared with the fuzzer
> function's main. However, as the fuzzer is using the tools/perf code
> as a library this causes backward linking reference that the linker
> may warn about.
> 
> v2. Remove references from commit messages about linking, as Adrian
>     points out we could solve that problem with #ifdefs.

Thanks, applied.

- Arnaldo

 
> Ian Rogers (6):
>   perf ui: Move window resize signal functions
>   perf usage: Move usage strings
>   perf header: Move perf_version_string declaration
>   perf version: Use regular verbose flag
>   perf util: Move input_name to util
>   perf util: Move perf_guest/host declarations
> 
>  tools/perf/builtin-annotate.c     |  2 +-
>  tools/perf/builtin-buildid-list.c |  2 +-
>  tools/perf/builtin-c2c.c          |  2 +-
>  tools/perf/builtin-data.c         |  2 +-
>  tools/perf/builtin-diff.c         |  2 +-
>  tools/perf/builtin-evlist.c       |  2 +-
>  tools/perf/builtin-help.c         |  1 +
>  tools/perf/builtin-kmem.c         |  2 +-
>  tools/perf/builtin-kvm.c          |  1 +
>  tools/perf/builtin-kwork.c        |  2 +-
>  tools/perf/builtin-mem.c          |  2 +-
>  tools/perf/builtin-sched.c        |  2 +-
>  tools/perf/builtin-stat.c         |  2 +-
>  tools/perf/builtin-timechart.c    |  2 +-
>  tools/perf/builtin-version.c      |  7 +++----
>  tools/perf/builtin.h              |  3 ---
>  tools/perf/perf.c                 | 27 +--------------------------
>  tools/perf/perf.h                 |  9 ---------
>  tools/perf/ui/browsers/hists.c    |  2 +-
>  tools/perf/ui/hist.c              |  2 +-
>  tools/perf/ui/setup.c             | 19 +++++++++++++++++++
>  tools/perf/ui/tui/setup.c         |  1 -
>  tools/perf/ui/ui.h                |  3 +++
>  tools/perf/util/cs-etm.c          |  1 +
>  tools/perf/util/event.c           |  2 +-
>  tools/perf/util/evlist.c          |  1 +
>  tools/perf/util/header.h          |  2 ++
>  tools/perf/util/parse-events.c    |  2 +-
>  tools/perf/util/session.c         |  2 +-
>  tools/perf/util/top.c             |  2 +-
>  tools/perf/util/usage.c           |  6 ++++++
>  tools/perf/util/util.c            |  2 ++
>  tools/perf/util/util.h            |  8 ++++++++
>  33 files changed, 66 insertions(+), 61 deletions(-)
> 
> -- 
> 2.40.0.577.gac1e443424-goog
> 

-- 

- Arnaldo