linux-kernel - Re: [PATCH v5 2/2] spi: dw: Add dma controller capability checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDV4q79uHy5aGdT1@smile.fi.intel.com>
Date:   Tue, 11 Apr 2023 18:11:39 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Joy Chakraborty <joychakr@...gle.com>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, manugautam@...gle.com,
        rohitner@...gle.com
Subject: Re: [PATCH v5 2/2] spi: dw: Add dma controller capability checks

On Tue, Apr 11, 2023 at 08:30:41PM +0530, Joy Chakraborty wrote:
> On Tue, Apr 11, 2023 at 5:48 PM Andy Shevchenko
> <andriy.shevchenko@...el.com> wrote:
> > On Thu, Mar 30, 2023 at 06:34:50AM +0000, Joy Chakraborty wrote:

...

> > > +static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes);
> >
> > Can we avoid forward declarations please?
> 
> We can, but for that I would have to move this api somewhere else in
> the file is that acceptable?

Yes, but make it in a separate change as a preparation for this one.

-- 
With Best Regards,
Andy Shevchenko