linux-kernel - RE: [PATCH v3 0/3] regulator: da9063: disable unused voltage monitors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <OS3PR01MB84601A473F8466C5923D8965C29A9@OS3PR01MB8460.jpnprd01.prod.outlook.com>
Date:   Tue, 11 Apr 2023 15:21:06 +0000
From:   DLG Adam Ward <DLG-Adam.Ward.opensource@...renesas.com>
To:     Benjamin Bara <bbara93@...il.com>,
        Support Opensource <support.opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Steve Twiss <stwiss.opensource@...semi.com>
CC:     DLG Adam Thomson <DLG-Adam.Thomson.Opensource@...renesas.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Benjamin Bara <benjamin.bara@...data.com>
Subject: RE: [PATCH v3 0/3] regulator: da9063: disable unused voltage monitors

On 05/04/2023, 19:14, Benjamin Bara wrote: 

>Hi!
>
>Follow-up for my initial patch regarding the disabling of unused
>voltage monitors. We use the PWR_OK functionality, which asserts GP_FB2
>if every monitored voltage is in range. This patch should provide the
>possibility to deactivate a voltage monitor from the DT if the regulator
>might be disabled during run time. For this purpose, the regulator
>notification support is used:
>https://lore.kernel.org/all/cover.1622628333.git.matti.vaittinen@xxxxxxxxxxxxxxxxx/
>
>v2: https://lore.kernel.org/r/20230403-da9063-disable-unused-v2-0-2f1bd2a2434a@xxxxxxxxxxx
>
>---
>Changelog:
>v3:
>2:
>- add clarifications, reword XVP to voltage monitoring
>- improve error messages
>- ensure that only one severity is set
>3:
-> document that ov and uv require same severity and level
>
>v2:
>- reworked solution, based on Adam Thomson's feedback
>
>---
>Benjamin Bara (3):
>      regulator: da9063: add voltage monitoring registers
>      regulator: da9063: implement setter for voltage monitoring
>      dt-bindings: mfd: dlg,da9063: document voltage monitoring
>
> .../devicetree/bindings/mfd/dlg,da9063.yaml        |  17 ++-
> drivers/regulator/da9063-regulator.c               | 147 +++++++++++++++++----
> include/linux/mfd/da9063/registers.h               |  23 ++++
> 3 files changed, 157 insertions(+), 30 deletions(-)
>---
>base-commit: 7e364e56293bb98cae1b55fd835f5991c4e96e7d
>change-id: 20230403-da9063-disable-unused-15836e2f4539
>
>Best regards,
>-- 
>Benjamin Bara <benjamin.bara@...xxxxxxxx>

Hi Benjamin,

FYI, Adam Thomson has left the company - but, being on excellent terms, kindly added his informed reading of your latest patch set to my own.

Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@...renesas.com>

Thanks and kind regards,
Adam