linux-kernel - Re: [PATCH 05/10] arm64: dts: qcom: sc8280xp: remove superfluous "input-enable"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Apr 2023 19:07:20 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] arm64: dts: qcom: sc8280xp: remove superfluous
 "input-enable"

On 11/04/2023 16:12, Johan Hovold wrote:
> On Fri, Apr 07, 2023 at 07:58:02PM +0200, Krzysztof Kozlowski wrote:
>> Pin configuration property "input-enable" was used with the intention to
>> disable the output, but this is done by default by Linux drivers.  Since
>> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
>> input-enable") the property is not accepted anymore.
> 
> This description does not seem to match the pin configurations that you
> are changing below which use the "qcom,sc8280xp-lpass-lpi-pinctrl"
> binding for which 'input-enable' is still accepted AFAICT.
> 
> Perhaps you can fix up the lpass bindings (and driver?) to match?

Thanks for spotting this. This change is wrong.

Best regards,
Krzysztof