linux-kernel - Re: [PATCH net-next v6 07/18] tcp: Support MSG_SPLICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4138303.1681235380@warthog.procyon.org.uk>
Date:   Tue, 11 Apr 2023 18:49:40 +0100
From:   David Howells <dhowells@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        David Ahern <dsahern@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@...radead.org>,
        Jens Axboe <axboe@...nel.dk>, Jeff Layton <jlayton@...nel.org>,
        Christian Brauner <brauner@...nel.org>,
        Chuck Lever III <chuck.lever@...cle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH net-next v6 07/18] tcp: Support MSG_SPLICE_PAGES

Eric Dumazet <edumazet@...gle.com> wrote:

> > -                       zc = sk->sk_route_caps & NETIF_F_SG;
> > +                       if (sk->sk_route_caps & NETIF_F_SG)
> > +                               zc = 1;
> 
> zc is set to 0, 1, MSG_ZEROCOPY ,   MSG_SPLICE_PAGES
> 
> I find this a bit confusing. Maybe use a private enum ?

Meh.  That should be "zc = MSG_ZEROCOPY;".  Will fix.

David