linux-kernel - Re: [PATCH] drm/armada: Fix a potential double free in an error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3c82938-7db0-2c0b-7784-c2096570c940@wanadoo.fr>
Date:   Tue, 11 Apr 2023 20:09:40 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     linux@...linux.org.uk, daniel@...ll.ch,
        David Airlie <airlied@...il.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm/armada: Fix a potential double free in an error
 handling path

Le 26/12/2021 à 17:34, Christophe JAILLET a écrit :
> 'priv' is a managed resource, so there is no need to free it explicitly or
> there will be a double free().
> 
> Fixes: 90ad200b4cbc ("drm/armada: Use devm_drm_dev_alloc")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/gpu/drm/armada/armada_drv.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
> index 8e3e98f13db4..54168134d9b9 100644
> --- a/drivers/gpu/drm/armada/armada_drv.c
> +++ b/drivers/gpu/drm/armada/armada_drv.c
> @@ -99,7 +99,6 @@ static int armada_drm_bind(struct device *dev)
>   	if (ret) {
>   		dev_err(dev, "[" DRM_NAME ":%s] can't kick out simple-fb: %d\n",
>   			__func__, ret);
> -		kfree(priv);
>   		return ret;
>   	}
>   

Hi,

polite reminder. (I've updated the mails according to the output of 
get_maintainer.pl)

The patch still LGTM and should apply cleanly.

CJ