linux-kernel - Re: [PATCH v2 1/7] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Apr 2023 20:16:36 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rafael@...nel.org, rui.zhang@...el.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Amit Kucheria <amitk@...nel.org>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Tim Zimmermann <tim@...ux4.de>
Subject: Re: [PATCH v2 1/7] thermal/drivers/intel_pch_thermal: Use thermal
 driver device to write a trace

On Mon, Apr 10, 2023 at 10:53 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> The pch_critical() callback accesses the thermal zone device structure
> internals, it dereferences the thermal zone struct device and the 'type'.
>
> For the former, the driver related device should be use instead and
> for the latter an accessor already exists. Use them instead of
> accessing the internals.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/thermal/intel/intel_pch_thermal.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
> index dce50d239357..0de46057db2a 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -127,7 +127,10 @@ static int pch_thermal_get_temp(struct thermal_zone_device *tzd, int *temp)
>
>  static void pch_critical(struct thermal_zone_device *tzd)
>  {
> -       dev_dbg(&tzd->device, "%s: critical temperature reached\n", tzd->type);
> +       struct pch_thermal_device *ptd = thermal_zone_device_priv(tzd);
> +
> +       dev_dbg(&ptd->pdev->dev, "%s: critical temperature reached\n",
> +               thermal_zone_device_type(tzd));

No, this just makes the code more complex than it is and the only
reason seems to be "cleanliness".

Something like

thermal_zone_dbg(tzd, "critical temperature reached\n");

would work, the above doesn't.  Sorry.

>  }
>
>  static struct thermal_zone_device_ops tzd_ops = {
> --