linux-kernel - Re: [PATCH v2 5/7] thermal/core: Prepare sanitizing thermal class sysfs content

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iOPsQKrnK3UsR+9vLhTf2jysTAEJD+71aeyfT8Gy1R1Q@mail.gmail.com>
Date:   Tue, 11 Apr 2023 20:23:14 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rafael@...nel.org, rui.zhang@...el.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Amit Kucheria <amitk@...nel.org>
Subject: Re: [PATCH v2 5/7] thermal/core: Prepare sanitizing thermal class
 sysfs content

On Mon, Apr 10, 2023 at 10:53 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> Some drivers are accessing the thermal zone device structure to create
> specific entries in /sys/class/thermal regardless the documentation.
>
> It is questionable as the specific information should be in the
> driver's sysfs directory, not the framework it is dealing with.
>
> It has been long time these specific attributes were added in the
> thermal sysfs directory and are limited to the ACPI thermal driver and
> the Menlon driver.
>
> It is probable those are not really needed, so in order to figure out
> if that is the case, let's create a default option disabling the
> attribute in order to prepare a definitive removal.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/thermal/Kconfig | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 4cd7ab707315..cca4e5cf6f30 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -33,6 +33,18 @@ config THERMAL_STATISTICS
>
>           If in doubt, say N.
>
> +config THERMAL_SYSFS_OBSOLETE_SINGULARITY
> +       bool "Enable obsolete and undocumented sysfs extra information"

I was talking about making an extra Kconfig option in the Menlow
driver to make the extra sysfs stuff depend on.

Throwing ACPI in the same bucket is a non-starter.

> +       def_bool n
> +       help
> +         Enable sysfs extra information added in the thermal zone and
> +         the driver specific sysfs directories. That could be a link
> +         to the associated thermal zone as well as a link pointing to
> +         the device from the thermal zone. By default those are
> +         disabled and are candidate for removal, if you need these
> +         information anyway, enable the option or upgrade the
> +         userspace program using them.
> +
>  config THERMAL_EMERGENCY_POWEROFF_DELAY_MS
>         int "Emergency poweroff delay in milli-seconds"
>         default 0
> --
> 2.34.1
>