[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAFBinCCXYnChN8MfOxGEDSTm4HftpzuwwHwtqm7b1dPH6EdUsQ@mail.gmail.com>
Date: Tue, 11 Apr 2023 21:30:18 +0200
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: Karl Chan <exkcmailist@...ox.lv>
Cc: linux-amlogic@...ts.infradead.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, neil.armstrong@...aro.org,
khilman@...libre.com, jbrunet@...libre.com,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Karl Chan <exxxxkc@...googleoff.me>
Subject: Re: [PATCH v3 2/2] arm64: dts: meson-gxl: add support for Xiaomi
Mibox 3
Hello Karl,
On Mon, Apr 10, 2023 at 9:31 PM Karl Chan <exkcmailist@...ox.lv> wrote:
>
> From: "Karl Chan" <exkcmailist@...ox.lv>
>
> The Xiaomi Mibox 3 is a TV box based on the Amlogic S905X chipset.
I found various websites referring to this device as "Mi Box 3" (so
space between Mi and Box).
Do you know the official name that Xiaomi used?
> There are two variants:
> - 2 GiB/8GIB
> - 1 GiB/4GIB
>
> Both variants come with:
> - 802.11a/b/g/n/ac wifi (BCM4345)
> - HDMI , AV (CVBS) and S/PDIF optical output
nit-pick: no space before the comma
> - 1x USB (utilizing both USB ports provided by the SoC)
Can you please explain this in a bit more detail?
My understanding is that this board has one USB 2.0 type A port. What
do you mean by "utilizing both USB ports"?
Also I'm curious: does the board come with eMMC or (raw/parallel) NAND
flash? P212 typically means eMMC.
[...]
> +/* This UART is brought out to the uart pad on the pcb*/
nit-pick: missing space after "pcb"
Are the UART pads obvious on the board (for example since they are
labelled)? If not: maybe add a hint where to find it
[...]
> +&usb {
> + status = "okay";
> + dr_mode = "host";
> +};
This is already inherited from meson-gxl-s905x-p212.dtsi so removing
it should result in the same .dtb
Best regards,
Martin
Powered by blists - more mailing lists