linux-kernel - Re: [PATCH] scsi: lpfc: silence an incorrect device output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPRKS9TbZO7NmknHfNEaxuY3EGGmR_NOcbBuM1ooba_R-3yiQ@mail.gmail.com>
Date:   Tue, 11 Apr 2023 14:31:55 -0700
From:   Justin Tee <justintee8345@...il.com>
To:     Jun Chen <jun_c@...t.edu.cn>
Cc:     James Smart <james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        Justin Tee <justin.tee@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Dongliang Mu <dzm91@...t.edu.cn>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: silence an incorrect device output

Hi Jun,

Broadcom no longer supports LPFC_SLI_INTF_IF_TYPE_1 adapters, but the
patch looks fine.

Reviewed-by: Justin Tee <justin.tee@...adcom.com>

Thanks,
Justin

On Sun, Apr 9, 2023 at 8:14 PM Jun Chen <jun_c@...t.edu.cn> wrote:
>
> In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a
> break statement, resulting in an incorrect device output.
>
> Fix this by adding a break statement before the default option.
>
> Signed-off-by: Jun Chen <jun_c@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---
>  drivers/scsi/lpfc/lpfc_init.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index d062220d3232..da3a45441639 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -12105,6 +12105,7 @@ lpfc_sli4_pci_mem_unset(struct lpfc_hba *phba)
>                         iounmap(phba->sli4_hba.dpp_regs_memmap_p);
>                 break;
>         case LPFC_SLI_INTF_IF_TYPE_1:
> +               break;
>         default:
>                 dev_printk(KERN_ERR, &phba->pcidev->dev,
>                            "FATAL - unsupported SLI4 interface type - %d\n",
> --
> 2.25.1
>