linux-kernel - Re: [PATCH] Documentation: firmware: Clarify firmware path usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db25c4cb-e786-d17c-d82a-c2450f4226a2@gmail.com>
Date:   Tue, 11 Apr 2023 15:21:31 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jonathan Corbet <corbet@....net>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH] Documentation: firmware: Clarify firmware path usage

On 4/11/23 15:20, Jonathan Corbet wrote:
> Greg KH <gregkh@...uxfoundation.org> writes:
> 
>> On Mon, Apr 10, 2023 at 04:12:32PM -0700, Florian Fainelli wrote:
>>> I was not sure whether it was on purpose or not, Greg, will we break
>>> anyone's use case if we strip off \n from the firmware path passed via
>>> sysfs?
>>
>> I do not know, sorry.
> 
> I would be amazed if anybody is putting newlines into their firmware
> path; that would be kind of a silly thing to do.
> 
> That said, I've been amazed before.
> 
> I'll go ahead and apply the docs patch, but it still doesn't really seem
> like the right fix to me.

I will submit a patch that strips off newlines from sysfs provided 
firmware paths and if this turns out to break someone's use case it 
could still be reverted, sounds good?
-- 
Florian