linux-kernel - Re: [PATCH V2,net-next, 3/3] net: mana: Add support for jumbo frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7287f315-0ac9-eef1-850f-8d8a91effe3d@intel.com>
Date:   Tue, 11 Apr 2023 16:12:55 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>,
        <linux-hyperv@...r.kernel.org>, <netdev@...r.kernel.org>
CC:     <decui@...rosoft.com>, <kys@...rosoft.com>,
        <paulros@...rosoft.com>, <olaf@...fle.de>, <vkuznets@...hat.com>,
        <davem@...emloft.net>, <wei.liu@...nel.org>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <leon@...nel.org>,
        <longli@...rosoft.com>, <ssengar@...ux.microsoft.com>,
        <linux-rdma@...r.kernel.org>, <daniel@...earbox.net>,
        <john.fastabend@...il.com>, <bpf@...r.kernel.org>,
        <ast@...nel.org>, <sharmaajay@...rosoft.com>, <hawk@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2,net-next, 3/3] net: mana: Add support for jumbo frame



On 4/7/2023 1:59 PM, Haiyang Zhang wrote:
> During probe, get the hardware-allowed max MTU by querying the device
> configuration. Users can select MTU up to the device limit.
> When XDP is in use, limit MTU settings so the buffer size is within
> one page.
> Also, to prevent changing MTU fails, and leaves the NIC in a bad state,
> pre-allocate all buffers before starting the change. So in low memory
> condition, it will return error, without affecting the NIC.
> 

What happens if XDP gets enabled after MTU larger than PAGE_SIZE is set?
Will XDP fail to enable in that case?

Thanks,
Jake