linux-kernel - Re: [PATCH net-next v4 11/12] net: stmmac: dwmac-qcom-ethqos: Use loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9819f309-7542-4182-0e7d-a85b6ac9bf58@intel.com>
Date:   Tue, 11 Apr 2023 16:45:34 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Andrew Halaney <ahalaney@...hat.com>,
        <linux-kernel@...r.kernel.org>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <vkoul@...nel.org>, <bhupesh.sharma@...aro.org>, <wens@...e.org>,
        <jernej.skrabec@...il.com>, <samuel@...lland.org>,
        <mturquette@...libre.com>, <peppe.cavallaro@...com>,
        <alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>,
        <mcoquelin.stm32@...il.com>, <richardcochran@...il.com>,
        <linux@...linux.org.uk>, <veekhee@...le.com>,
        <tee.min.tan@...ux.intel.com>, <mohammad.athari.ismail@...el.com>,
        <jonathanh@...dia.com>, <ruppala@...dia.com>, <bmasney@...hat.com>,
        <andrey.konovalov@...aro.org>, <linux-arm-msm@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <ncai@...cinc.com>,
        <jsuraj@....qualcomm.com>, <hisunil@...cinc.com>,
        <echanude@...hat.com>
Subject: Re: [PATCH net-next v4 11/12] net: stmmac: dwmac-qcom-ethqos: Use
 loopback_en for all speeds

On 4/11/2023 1:04 PM, Andrew Halaney wrote:
> It seems that this variable should be used for all speeds, not just
> 1000/100.
> 
> While at it refactor it slightly to be more readable, including fixing
> the typo in the variable name.
> 
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>

Would prefer the future use of bitfields in a u8 instead of a bool in
structs, but it's really a nit, and they're already there you're just
renaming them.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>