linux-kernel - Re: [PATCH] staging: rtl8192e: Fix logical operator continuations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 22:32:15 -0700
From:   Sumitra Sharma <sumitraartsy@...il.com>
To:     Alison Schofield <alison.schofield@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Fix logical operator continuations

On Mon, Apr 10, 2023 at 05:07:12PM -0700, Alison Schofield wrote:
> On Sat, Apr 08, 2023 at 10:18:03AM -0700, Sumitra Sharma wrote:
> > Fix logical operator continuation as suggested by Linux kernel
> > coding-style. Check reported by checkpatch:
> > 
> > CHECK: Logical continuations should be on the previous line
> > 
> > Signed-off-by: Sumitra Sharma <sumitraartsy@...il.com>
> 
> Hi Sumitra,
> 
> That commit message can be explicit, like "Move logical operator
> to previous line"
>

Hi Alison

Okay I will change it. Thank you.

Regards
Sumitra

> Alison
> 
> 
> > ---
> >  drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > index 5a1cd22f5e25..58ed394202ae 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > @@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
> >  					&priv->rtllib->pwr_save_ctrl;
> >  
> >  	if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> > -	    (priv->rtllib->state == RTLLIB_LINKED))
> > -	    || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> > +	    (priv->rtllib->state == RTLLIB_LINKED)) ||
> > +	    (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> >  	    (priv->rtllib->iw_mode == IW_MODE_MASTER))
> >  		return;
> >  
> > -- 
> > 2.25.1
> >