linux-kernel - Re: [PATCH v2 1/2] dt-bindings: drm/bridge: Add no-hpd property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ba8bbcf-0d72-4bb9-a014-85e9f3e22cdb@linaro.org>
Date:   Tue, 11 Apr 2023 08:06:41 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jayesh Choudhary <j-choudhary@...com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     andrzej.hajda@...el.com, neil.armstrong@...aro.org,
        rfoss@...nel.org, Laurent.pinchart@...asonboard.com,
        jonas@...boo.se, jernej.skrabec@...il.com, airlied@...il.com,
        daniel@...ll.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, sam@...nborg.org,
        jani.nikula@...el.com, tzimmermann@...e.de, javierm@...hat.com,
        ville.syrjala@...ux.intel.com, r-ravikumar@...com,
        lyude@...hat.com, alexander.deucher@....com, sjakhade@...ence.com,
        yamonkar@...ence.com, a-bhatia1@...com,
        tomi.valkeinen@...asonboard.com
Subject: Re: [PATCH v2 1/2] dt-bindings: drm/bridge: Add no-hpd property

On 05/04/2023 16:24, Jayesh Choudhary wrote:
> From: Rahul T R <r-ravikumar@...com>
> 
> The mhdp bridge can work without its HPD pin hooked up to the connector,
> but the current bridge driver throws an error when hpd line is not
> connected to the connector. For such cases, we need an indication for
> no-hpd, using which we can bypass the hpd detection and instead use the
> auxiliary channels connected to the DP connector to confirm the
> connection.
> So add no-hpd property to the bindings, to disable hpd when not
> connected or unusable.

Your subject prefixes miss device specific part. You do not add no-hpd
to all bridges.

It's also not drm. It is a display directory.

> 
> Signed-off-by: Rahul T R <r-ravikumar@...com>
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> ---
>  .../devicetree/bindings/display/bridge/cdns,mhdp8546.yaml   | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> index c2b369456e4e..3a6c6d837593 100644
> --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> @@ -57,6 +57,12 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  cdns,no-hpd:

No improvements - use existing no-hpd name.



Best regards,
Krzysztof