lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20230411162053.0adfd01a@canb.auug.org.au>
Date:   Tue, 11 Apr 2023 16:20:53 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Rob Herring <robherring2@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: linux-next: build failures after merge of the devicetree tree

Hi all,

After merging the devicetree tree, today's linux-next build (i386
defconfig) failed like this:

In file included from kernel/irq/irqdomain.c:15:
include/linux/of_address.h:111:12: error: 'of_property_read_reg' defined but not used [-Werror=unused-function]
  111 | static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
      |            ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/property.c:14:
include/linux/of_address.h:111:12: error: 'of_property_read_reg' defined but not used [-Werror=unused-function]
  111 | static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
      |            ^~~~~~~~~~~~~~~~~~~~
In file included from lib/devres.c:7:
include/linux/of_address.h:111:12: error: 'of_property_read_reg' defined but not used [-Werror=unused-function]
  111 | static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
      |            ^~~~~~~~~~~~~~~~~~~~

Introduced by commit

  87b764b15f9a ("of/address: Add of_property_read_reg() helper")

I applied the following fix patch:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Tue, 11 Apr 2023 16:09:19 +1000
Subject: [PATCH] of/address: fixup for "Add of_property_read_reg() helper"

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 include/linux/of_address.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/of_address.h b/include/linux/of_address.h
index 95cb6c5c2d67..26a19daf0d09 100644
--- a/include/linux/of_address.h
+++ b/include/linux/of_address.h
@@ -108,7 +108,7 @@ static inline const __be32 *__of_get_address(struct device_node *dev, int index,
 	return NULL;
 }
 
-static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
+static inline int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
 {
 	return -ENOSYS;
 }
-- 
2.39.2

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ