linux-kernel - Re: [PATCH v2] fsverity: use WARN_ON_ONCE instead of WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Apr 2023 10:58:03 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     fsverity@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chaitanya Kulkarni <kch@...dia.com>
Subject: Re: [PATCH v2] fsverity: use WARN_ON_ONCE instead of WARN_ON

On Thu, Apr 06, 2023 at 11:25:25AM -0700, Eric Biggers wrote:
> On Thu, Apr 06, 2023 at 11:15:42AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > As per Linus's suggestion
> > (https://lore.kernel.org/r/CAHk-=whefxRGyNGzCzG6BVeM=5vnvgb-XhSeFJVxJyAxAF8XRA@mail.gmail.com),
> > use WARN_ON_ONCE instead of WARN_ON.  This barely adds any extra
> > overhead, and it makes it so that if any of these ever becomes reachable
> > (they shouldn't, but that's the point), the logs can't be flooded.
> > 
> > Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > ---
> >  fs/verity/enable.c       | 4 ++--
> >  fs/verity/hash_algs.c    | 4 ++--
> >  fs/verity/open.c         | 2 +-
> >  include/linux/fsverity.h | 6 +++---
> >  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> Sorry, forgot changelog:
> 
> v2: also convert the three WARN_ON in include/linux/fsverity.h

Looks good to me,
Reviewed-by: Christian Brauner <brauner@...nel.org>