linux-kernel - Re: [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b42f7c48-84b1-1e50-bcad-1bf5edf1a168@linaro.org>
Date:   Tue, 11 Apr 2023 13:05:39 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous
 "input-enable"



On 10.04.2023 20:10, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers.  Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts    | 2 --
>  arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts | 1 -
>  arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts        | 3 ---
>  3 files changed, 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> index 7a80e1c9f126..aa0e0e8d2a97 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> @@ -268,7 +268,6 @@ bluetooth_default_state: bluetooth-default-state {
>  		function = "gpio";
>  		drive-strength = <8>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_hostwake_default_state: wlan-hostwake-default-state {
> @@ -276,7 +275,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> index d64096028ab1..5593a3a60d6c 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> @@ -352,7 +352,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> index b82381229adf..b887e5361ec3 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> @@ -307,7 +307,6 @@ bluetooth_default_state: bluetooth-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	touch_pins: touch-state {
> @@ -317,7 +316,6 @@ irq-pins {
>  
>  			drive-strength = <8>;
>  			bias-pull-down;
> -			input-enable;
>  		};
>  
>  		reset-pins {
> @@ -335,7 +333,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_regulator_default_state: wlan-regulator-default-state {