linux-kernel - Re: [PATCH] ASoC: soc-compress: set pcm nonatomic flag from dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7af7475e-e8d3-6cf0-d879-4f9599bd1cfd@linaro.org>
Date:   Tue, 11 Apr 2023 14:30:36 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        broonie@...nel.org
Cc:     tiwai@...e.com, lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org,
        Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH] ASoC: soc-compress: set pcm nonatomic flag from dai_link



On 11/04/2023 14:25, Pierre-Louis Bossart wrote:
> 
> 
> On 4/11/23 06:08, Srinivas Kandagatla wrote:
>> In compress offload case we never set nonatomic flag on a new pcm. This triggers
>> below configuration error with DPCM on Qualcomm setup where dai_links are marked
>> as nonatomic.
>>
>> "FE is atomic but BE is nonatomic, invalid configuration"
>>
>> Fix this by Updating the pcm nonatomic flag correcly from the respective dai_link.
>>
>> CC: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>>   sound/soc/soc-compress.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
>> index 554c329ec87f..a8d70274cab8 100644
>> --- a/sound/soc/soc-compress.c
>> +++ b/sound/soc/soc-compress.c
>> @@ -615,6 +615,7 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
>>   			return ret;
>>   		}
>>   
>> +		be_pcm->nonatomic = rtd->dai_link->nonatomic;
>>   		rtd->pcm = be_pcm;
>>   		rtd->fe_compr = 1;
>>   		if (rtd->dai_link->dpcm_playback)
> 
> isn't this fixed already? Daniel Baluta sent a patch for this, already
> applied by Mark:
> 

Thanks for pointing this, Yes, It is fixed in sound-next.. my branch was 
a week+ old so did not spot it :-)

--srini
> https://lore.kernel.org/alsa-devel/20230324124019.30826-1-daniel.baluta@oss.nxp.com/