linux-kernel - Re: [PATCH] dt-bindings: PCI: Fix unit address of example root port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZDVhVYZ838ksVMYP@hovoldconsulting.com>
Date:   Tue, 11 Apr 2023 15:32:05 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: Fix unit address of example root port

On Wed, Apr 05, 2023 at 08:38:29AM -0500, Rob Herring wrote:
> On Wed, Apr 5, 2023 at 6:19 AM Johan Hovold <johan@...nel.org> wrote:
> >
> > On Fri, Mar 17, 2023 at 12:20:19PM +0100, Johan Hovold wrote:
> > > Fix the unit address of the example root port which is identical to the
> > > device number (i.e. 1).
> > >
> > > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > > ---
> >
> > This one hasn't showed up in linux-next yet. Could you pick it up for
> > 6.4, Lorenzo?
> 
> On 2nd thought, I think it's time to just remove this file. The schema
> is just missing some descriptions and 1 property (external-facing).
> I've added all that here[1].

Sounds good to me. Will you send a patch?

> I didn't add the example to the schema because the example here is
> incomplete and won't validate.

Fair enough. Having a decent example in the tree would be helpful, but
hopefully we can get the in-tree DT sources up to par at some point so
that they can serve that purpose.

Johan

> [1] https://github.com/robherring/dt-schema/commit/8445eb010e61496681e2504faf400e9fbc5b1acf