linux-kernel - Re: [PATCH RESEND] mtd: onenand: omap2: Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Apr 2023 15:41:55 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH RESEND] mtd: onenand: omap2: Drop obsolete dependency on
 COMPILE_TEST

Hi Jean,

jdelvare@...e.de wrote on Fri, 7 Apr 2023 19:04:53 +0200:

> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Vignesh Raghavendra <vigneshr@...com>
> ---
> Even though this was supposedly accepted a few months ago already, I
> can't find this commit, neither upstream nor in the nand/next,
> therefore resending.

I have no idea what I did wrong but I definitely messed up, I can't
find this patch while it is marked Accepted in patchwork and I actually
answered that I applied it. It is especially strange since its
cousin applying to raw NAND was correctly taken. Sorry for the mess,
I'll really take it this time.

> 
>  drivers/mtd/nand/onenand/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-6.2.orig/drivers/mtd/nand/onenand/Kconfig
> +++ linux-6.2/drivers/mtd/nand/onenand/Kconfig
> @@ -25,7 +25,7 @@ config MTD_ONENAND_GENERIC
>  config MTD_ONENAND_OMAP2
>  	tristate "OneNAND on OMAP2/OMAP3 support"
>  	depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && ARM)
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	depends on OMAP_GPMC
>  	help
>  	  Support for a OneNAND flash device connected to an OMAP2/OMAP3 SoC
> 
> 

Thanks,
Miquèl