linux-kernel - RE: [PATCH v3] rcu/kvfree: Prevents cache growing when the backoff_page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5880C4B181B6237402B1FBA7DA9A9@PH0PR11MB5880.namprd11.prod.outlook.com>
Date:   Tue, 11 Apr 2023 14:42:27 +0000
From:   "Zhang, Qiang1" <qiang1.zhang@...el.com>
To:     Uladzislau Rezki <urezki@...il.com>
CC:     "paulmck@...nel.org" <paulmck@...nel.org>,
        "frederic@...nel.org" <frederic@...nel.org>,
        "joel@...lfernandes.org" <joel@...lfernandes.org>,
        "qiang.zhang1211@...il.com" <qiang.zhang1211@...il.com>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] rcu/kvfree: Prevents cache growing when the
 backoff_page_cache_fill is set

> > Currently, in kfree_rcu_shrink_scan(), the drain_page_cache() is
> > executed before kfree_rcu_monitor() to drain page cache, if the bnode
> > structure's->gp_snap has done, the kvfree_rcu_bulk() will fill the
> > page cache again in kfree_rcu_monitor(), this commit add a check
> > for krcp structure's->backoff_page_cache_fill in put_cached_bnode(),
> > if the krcp structure's->backoff_page_cache_fill is set, prevent page
> > cache growing and disable allocated page in fill_page_cache_func().
> > 
> > Signed-off-by: Zqiang <qiang1.zhang@...el.com>
> >
> >Much improved!  But still some questions below...
> >
> >							Thanx, Paul
> >
> > ---
> >  kernel/rcu/tree.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index cc34d13be181..9d9d3772cc45 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -2908,6 +2908,8 @@ static inline bool
> >  put_cached_bnode(struct kfree_rcu_cpu *krcp,
> >  	struct kvfree_rcu_bulk_data *bnode)
> >  {
> > +	if (atomic_read(&krcp->backoff_page_cache_fill))
> > +		return false;
> >
> >This will mean that under low-memory conditions, we will keep zero
> >pages in ->bkvcache.  All attempts to put something there will fail.
> >
> >This is probably not an issue for structures containing an rcu_head
> >that are passed to kfree_rcu(p, field), but doesn't this mean that
> >kfree_rcu_mightsleep() unconditionally invokes synchronize_rcu()?
> >This could seriously slow up freeing under low-memory conditions,
> >which might exacerbate the low-memory conditions.
> 
> Thanks for mentioning this, I didn't think of this before😊.
> 
> >
> >Is this really what we want?  Zero cached rather than just fewer cached?
> >
> >
> >
> >  	// Check the limit.
> >  	if (krcp->nr_bkv_objs >= rcu_min_cached_objs)
> >  		return false;
> > @@ -3221,7 +3223,7 @@ static void fill_page_cache_func(struct work_struct *work)
> >  	int i;
> >  
> >  	nr_pages = atomic_read(&krcp->backoff_page_cache_fill) ?
> > -		1 : rcu_min_cached_objs;
> > +		0 : rcu_min_cached_objs;
> >  
> >  	for (i = 0; i < nr_pages; i++) {
> >
> >I am still confused as to why we start "i" at zero rather than at
> >->nr_bkv_objs.  What am I missing here?
> 
> 
> No, you are right, I missed this place. 
> 
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2908,6 +2908,8 @@ static inline bool
>  put_cached_bnode(struct kfree_rcu_cpu *krcp,
>         struct kvfree_rcu_bulk_data *bnode)
>  {
> +       if (atomic_read(&krcp->backoff_page_cache_fill))
> +               return false;
>
>This is broken, unfortunately. If a low memory condition we fill
>fill a cache with at least one page anyway because of we do not want
>to hit a slow path.

Thanks remind, please ignore my v4 patch,   how about the following?

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 41daae3239b5..e2e8412e687f 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3238,6 +3238,9 @@ static void fill_page_cache_func(struct work_struct *work)
                        free_page((unsigned long) bnode);
                        break;
                }
+
+               if (atomic_read(&krcp->backoff_page_cache_fill))
+                       break;
        }

        atomic_set(&krcp->work_in_progress, 0);



>
>         // Check the limit.
>         if (krcp->nr_bkv_objs >= rcu_min_cached_objs)
>                 return false;
> @@ -3223,7 +3225,7 @@ static void fill_page_cache_func(struct work_struct *work)
>         nr_pages = atomic_read(&krcp->backoff_page_cache_fill) ?
>                 1 : rcu_min_cached_objs;
> 
> -       for (i = 0; i < nr_pages; i++) {
> +       for (i = krcp->nr_bkv_objs; i < nr_pages; i++) {
>                 bnode = (struct kvfree_rcu_bulk_data *)
>                         __get_free_page(GFP_KERNEL | __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN);
> 
> 
>IMHO, it should be send as a separate patch explaining why it
>it is needed.

Agree.

Thanks
Zqiang

>
>--
>Uladzislau Rezki