linux-kernel - Re: [PATCH V2,net-next, 2/3] net: mana: Enable RX path to handle various MTU sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96ad9a58-00c8-1bb3-06d6-841e7ea41488@intel.com>
Date:   Tue, 11 Apr 2023 08:06:31 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>,
        <linux-hyperv@...r.kernel.org>, <netdev@...r.kernel.org>
CC:     <decui@...rosoft.com>, <kys@...rosoft.com>,
        <paulros@...rosoft.com>, <olaf@...fle.de>, <vkuznets@...hat.com>,
        <davem@...emloft.net>, <wei.liu@...nel.org>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <leon@...nel.org>,
        <longli@...rosoft.com>, <ssengar@...ux.microsoft.com>,
        <linux-rdma@...r.kernel.org>, <daniel@...earbox.net>,
        <john.fastabend@...il.com>, <bpf@...r.kernel.org>,
        <ast@...nel.org>, <sharmaajay@...rosoft.com>, <hawk@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2,net-next, 2/3] net: mana: Enable RX path to handle
 various MTU sizes

On 4/7/2023 1:59 PM, Haiyang Zhang wrote:
> Update RX data path to allocate and use RX queue DMA buffers with
> proper size based on potentially various MTU sizes.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> ---
> V2:
> Refectored to multiple patches for readability. Suggested by Yunsheng Lin.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>

One tiny nit below, but not worth a respin.

> @@ -1764,6 +1798,7 @@ static struct mana_rxq *mana_create_rxq(struct mana_port_context *apc,
>  	struct mana_obj_spec wq_spec;
>  	struct mana_obj_spec cq_spec;
>  	struct gdma_queue_spec spec;
> +	unsigned int mtu = ndev->mtu;

This one isn't quite RCT order. I'd only change it if you have another
respin for some reason.

Ha, I see you remove that line in the next patch, never mind...