linux-kernel - Re: [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Apr 2023 10:03:50 -0500
From:   Rob Herring <robh@...nel.org>
To:     Patrick Delaunay <patrick.delaunay@...s.st.com>
Cc:     Alexandre TORGUE <alexandre.torgue@...s.st.com>,
        Lee Jones <lee@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file

On Fri, Apr 07, 2023 at 08:12:43PM +0200, Patrick Delaunay wrote:
> Minor cosmetic change, aligned with file in U-Boot:
> - remove extra space

extra blank line really.

Please make the subject reflect what the change is. This doesn't really 
'Fix' anything and it's so generic it could be any change. Just 'Remove 
double blank line' would be much better and defines the exact change.

> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@...s.st.com>
> ---
> 
>  include/dt-bindings/mfd/stm32f4-rcc.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h
> index 309e8c79f27b..36448a5619a1 100644
> --- a/include/dt-bindings/mfd/stm32f4-rcc.h
> +++ b/include/dt-bindings/mfd/stm32f4-rcc.h
> @@ -34,7 +34,6 @@
>  #define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8))
>  #define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit)
>  
> -
>  /* AHB2 */
>  #define STM32F4_RCC_AHB2_DCMI	0
>  #define STM32F4_RCC_AHB2_CRYP	4
> -- 
> 2.25.1
>