linux-kernel - Re: [PATCH v2] tools:perf:scripts:python:intel-pt-events del unusedvar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZDbMJkiJT2rD8MEj@kernel.org>
Date:   Wed, 12 Apr 2023 12:20:06 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Alexander Pantyukhin <apantykhin@...il.com>, mingo@...hat.com,
        namhyung@...nel.org, jolsa@...nel.org, akpm@...ux-foundation.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tools:perf:scripts:python:intel-pt-events del
 unusedvar

Em Mon, Jan 16, 2023 at 07:15:01AM +0200, Adrian Hunter escreveu:
> On 14/01/23 15:05, Alexander Pantyukhin wrote:
> > The event_attr is never used later, the var is ok be deleted.
> > Additional code simplification is to substitute string slice comparison
> > with "substring" function. This case no need to know the length specific
> > words.
> > 
> > Signed-off-by: Alexander Pantyukhin <apantykhin@...il.com>
> 
> Acked-by: Adrian Hunter <adrian.hunter@...el.com>

Finally picked this one,

- Arnaldo
 
> > ---
> >  tools/perf/scripts/python/intel-pt-events.py | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scripts/python/intel-pt-events.py
> > index 08862a2582f4..dfd566369ca4 100644
> > --- a/tools/perf/scripts/python/intel-pt-events.py
> > +++ b/tools/perf/scripts/python/intel-pt-events.py
> > @@ -340,7 +340,6 @@ def print_srccode(comm, param_dict, sample, symbol, dso, with_insn):
> >  	print(start_str, src_str)
> >  
> >  def do_process_event(param_dict):
> > -	event_attr = param_dict["attr"]
> >  	sample	   = param_dict["sample"]
> >  	raw_buf	   = param_dict["raw_buf"]
> >  	comm	   = param_dict["comm"]
> > @@ -349,6 +348,7 @@ def do_process_event(param_dict):
> >  	# callchain  = param_dict["callchain"]
> >  	# brstack    = param_dict["brstack"]
> >  	# brstacksym = param_dict["brstacksym"]
> > +	# event_attr = param_dict["attr"]
> >  
> >  	# Symbol and dso info are not always resolved
> >  	dso    = get_optional(param_dict, "dso")
> > @@ -359,13 +359,13 @@ def do_process_event(param_dict):
> >  		print(glb_switch_str[cpu])
> >  		del glb_switch_str[cpu]
> >  
> > -	if name[0:12] == "instructions":
> > +	if name.startswith("instructions"):
> >  		if glb_src:
> >  			print_srccode(comm, param_dict, sample, symbol, dso, True)
> >  		else:
> >  			print_instructions_start(comm, sample)
> >  			print_common_ip(param_dict, sample, symbol, dso)
> > -	elif name[0:8] == "branches":
> > +	elif name.startswith("branches"):
> >  		if glb_src:
> >  			print_srccode(comm, param_dict, sample, symbol, dso, False)
> >  		else:

-- 

- Arnaldo