linux-kernel - Re: [PATCH v1] net: mdio: fixed set gpio in ...switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ac3cd630-5b44-4f4b-8dad-9e17163db600@lunn.ch>
Date:   Wed, 12 Apr 2023 17:41:58 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Yan Wang <rocklouts@...a.com>
Cc:     hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        Russell King <linux@...linux.org.uk>,
        "open list:ETHERNET PHY LIBRARY" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] net: mdio: fixed set gpio in ...switch_fn()

On Wed, Apr 12, 2023 at 11:02:21PM +0800, Yan Wang wrote:
> DTS,e.g:
>      mdio_mux {
> 		compatible = "mdio-mux-gpio";
> 		pinctrl-0 = <&pinctrl_mdio_mux>;
> 		pinctrl-names = "default";
> 		gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>,<&gpio1 10 GPIO_ACTIVE_HIGH>;
> 		enable-gpios = <&gpio1 13 1>;
> 		mdio-parent-bus = <&mdio0>;
> 		#address-cells = <1>;
> 		#size-cells = <0>;
> 		mdio@.....};
> 		...
> 		mido@.....};
> 
>      };
> 
> If desired_child = 2, that don't control gpio1_10.I do not understand,
> but chang the third parameter to NULL of the gpiod_set_array_value_cansleep().
> it can work normally on the IMX8MP platform.

Please could you explain the problem you are seeing in more details.

What i think you mean is that then passing s->gpios->info, gpio1 10 is
not being set to the correct value?

If so, this is not the correct fix. It seems like either the IMX8MP
gpio driver is broken, or possibly there is a bug in the gpio core.
You need to find the real problem.

    Andrew