linux-kernel - Re: [PATCH 04/11] dmaengine: dw-axi-dmac: remove redudant axi_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDbsEX/98i30p88k@matsya>
Date:   Wed, 12 Apr 2023 23:06:17 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Jisheng Zhang <jszhang@...nel.org>
Cc:     Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/11] dmaengine: dw-axi-dmac: remove redudant
 axi_dma_disable() calling

On 14-03-23, 01:04, Jisheng Zhang wrote:
> axi_dma_suspend() will soon call axi_dma_disable(), remove the redudant

s/redudant/redundant

> axi_dma_disable() callin.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 891776528619..410222e7224c 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1535,7 +1535,6 @@ static int dw_remove(struct platform_device *pdev)
>  		axi_chan_disable(&chip->dw->chan[i]);
>  		axi_chan_irq_disable(&chip->dw->chan[i], DWAXIDMAC_IRQ_ALL);
>  	}
> -	axi_dma_disable(chip);
>  
>  	pm_runtime_disable(chip->dev);
>  	axi_dma_suspend(chip);
> -- 
> 2.39.2

-- 
~Vinod