linux-kernel - Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJaLiFw00VyD4rPBh=06U6wXmbDaK75Cd9MCVwUCN1SF4A1_Xw@mail.gmail.com>
Date:   Wed, 12 Apr 2023 11:50:47 -0700
From:   Tony Dinh <mibodhi@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Gregory Clement <gregory.clement@...tlin.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        linux-kernel@...r.kernel.org, soc@...nel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS

Hi Andrew,

On Wed, Apr 12, 2023 at 5:24 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +
> > +/ {
> > +     model = "Thecus N2350";
> > +     compatible = "marvell,armada385";
>
> If you look at all the other armarda-385 .dts files, they all have a
> board compatible. It might not be needed now, but it could be useful
> in the future and allow backwards compatibility.
>
> > +&mdio {
> > +     phy0: ethernet-phy@0 {
> > +             reg = <1>;
> > +     };
> > +};
>
> Since you have ref = <1>, this should be ethernet-phy@1.
>

Thanks! somehow I kept missing that change.

All the best,
Tony