linux-kernel - Re: [PATCH v4 0/6] KVM: selftests: Add "instructions required" testcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAAPnDFruYyoT=jT7+H=QXry0DHFyYCTO2cX=Nr=L4JH8g-Y4Q@mail.gmail.com>
Date:   Wed, 12 Apr 2023 23:06:41 +0000
From:   Aaron Lewis <aaronlewis@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/6] KVM: selftests: Add "instructions required" testcase

On Fri, Apr 7, 2023 at 11:33 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> This is the selftests portion of Aaron's series[*] to fix incorrect
> "instructions required" counting.  The big change from v3 is to use a

nit: here and in the subject, s/required/retired/.

> common struct to copy counter values to/from the guest instead of smushing
> the values into a single 64-bit value.
>
> [*] https://lkml.kernel.org/r/20230307141400.1486314-1-aaronlewis%40google.com
>
> Aaron Lewis (4):
>   KVM: selftests: Add a common helper for the PMU event filter guest
>     code
>   KVM: selftests: Add helpers for PMC asserts in PMU event filter test
>   KVM: selftests: Print detailed info in PMU event filter asserts
>   KVM: selftests: Test the PMU event "Instructions retired"
>
> Sean Christopherson (2):
>   KVM: selftests: Use error codes to signal errors in PMU event filter
>     test
>   KVM: selftests: Copy full counter values from guest in PMU event
>     filter test
>
>  .../kvm/x86_64/pmu_event_filter_test.c        | 252 ++++++++++--------
>  1 file changed, 140 insertions(+), 112 deletions(-)
>
>
> base-commit: b821bf96cf3bed0c1c8d34659299a3a1dc47218d
> --
> 2.40.0.577.gac1e443424-goog
>

Fingers crossed that marking this as "plain text" works this time.

Reviewed by: Aaron Lewis <aaronlewis@...gle.com>