| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202304120902.bP52A56z-lkp@intel.com>
Date: Wed, 12 Apr 2023 09:11:29 +0800
From: kernel test robot <lkp@...el.com>
To: Pankaj Gupta <pankaj.gupta@....com>, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
linux-imx@....com, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, gaurav.jain@....com,
sahil.malhotra@....com, aisheng.dong@....com, V.Sethi@....com
Cc: oe-kbuild-all@...ts.linux.dev, Pankaj Gupta <pankaj.gupta@....com>
Subject: Re: [NXP ELE-MUAP 6/7] firmware: imx: add ELE MU driver support
Hi Pankaj,
kernel test robot noticed the following build warnings:
[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on robh/for-next arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next rockchip/for-next soc/for-next linus/master v6.3-rc6 next-20230411]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pankaj-Gupta/doc-device-tree-binding-addition-for-ele-MU/20230411-231913
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/20230411162536.30604-7-pankaj.gupta%40nxp.com
patch subject: [NXP ELE-MUAP 6/7] firmware: imx: add ELE MU driver support
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230412/202304120902.bP52A56z-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/80f6b85e97e7f7eb4b5d59c638adb2bdbe6d48d1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Pankaj-Gupta/doc-device-tree-binding-addition-for-ele-MU/20230411-231913
git checkout 80f6b85e97e7f7eb4b5d59c638adb2bdbe6d48d1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/firmware/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304120902.bP52A56z-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:564,
from include/asm-generic/bug.h:22,
from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from arch/m68k/include/asm/irqflags.h:6,
from include/linux/irqflags.h:16,
from arch/m68k/include/asm/atomic.h:6,
from include/linux/atomic.h:7,
from include/linux/rcupdate.h:25,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/dma-mapping.h:7,
from drivers/firmware/imx/ele_mu.c:6:
drivers/firmware/imx/ele_mu.c: In function 'ele_mu_fops_write':
>> drivers/firmware/imx/ele_mu.h:17:47: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
17 | dev_dbg((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~
include/linux/dynamic_debug.h:223:29: note: in definition of macro '__dynamic_func_call_cls'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:272:9: note: in expansion of macro '_dynamic_func_call'
272 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:17:17: note: in expansion of macro 'dev_dbg'
17 | dev_dbg((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:36:9: note: in expansion of macro 'miscdev_dbg'
36 | miscdev_dbg(&((p_devctx)->miscdev), fmt, ##va_args)
| ^~~~~~~~~~~
drivers/firmware/imx/ele_mu.c:303:9: note: in expansion of macro 'devctx_dbg'
303 | devctx_dbg(dev_ctx, "write from buf (%p)%ld, ppos=%lld\n", buf, size,
| ^~~~~~~~~~
drivers/firmware/imx/ele_mu.h:31:47: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
31 | dev_err((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:31:17: note: in expansion of macro 'dev_err'
31 | dev_err((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:40:9: note: in expansion of macro 'miscdev_err'
40 | miscdev_err((&(p_devctx)->miscdev), fmt, ##va_args)
| ^~~~~~~~~~~
drivers/firmware/imx/ele_mu.c:315:17: note: in expansion of macro 'devctx_err'
315 | devctx_err(dev_ctx, "User buffer too small(%ld < %x)\n",
| ^~~~~~~~~~
drivers/firmware/imx/ele_mu.h:31:47: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
31 | dev_err((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:31:17: note: in expansion of macro 'dev_err'
31 | dev_err((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:40:9: note: in expansion of macro 'miscdev_err'
40 | miscdev_err((&(p_devctx)->miscdev), fmt, ##va_args)
| ^~~~~~~~~~~
drivers/firmware/imx/ele_mu.c:322:17: note: in expansion of macro 'devctx_err'
322 | devctx_err(dev_ctx, "User buffer too big(%ld > %lu)\n", size,
| ^~~~~~~~~~
>> drivers/firmware/imx/ele_mu.h:31:47: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=]
31 | dev_err((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:31:17: note: in expansion of macro 'dev_err'
31 | dev_err((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:40:9: note: in expansion of macro 'miscdev_err'
40 | miscdev_err((&(p_devctx)->miscdev), fmt, ##va_args)
| ^~~~~~~~~~~
drivers/firmware/imx/ele_mu.c:322:17: note: in expansion of macro 'devctx_err'
322 | devctx_err(dev_ctx, "User buffer too big(%ld > %lu)\n", size,
| ^~~~~~~~~~
drivers/firmware/imx/ele_mu.c: In function 'ele_mu_fops_read':
>> drivers/firmware/imx/ele_mu.h:17:47: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
17 | dev_dbg((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~
include/linux/dynamic_debug.h:223:29: note: in definition of macro '__dynamic_func_call_cls'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:272:9: note: in expansion of macro '_dynamic_func_call'
272 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:17:17: note: in expansion of macro 'dev_dbg'
17 | dev_dbg((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:36:9: note: in expansion of macro 'miscdev_dbg'
36 | miscdev_dbg(&((p_devctx)->miscdev), fmt, ##va_args)
| ^~~~~~~~~~~
drivers/firmware/imx/ele_mu.c:410:9: note: in expansion of macro 'devctx_dbg'
410 | devctx_dbg(dev_ctx, "read to buf %p(%ld), ppos=%lld\n", buf, size,
| ^~~~~~~~~~
drivers/firmware/imx/ele_mu.h:17:47: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
17 | dev_dbg((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~
include/linux/dynamic_debug.h:223:29: note: in definition of macro '__dynamic_func_call_cls'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:272:9: note: in expansion of macro '_dynamic_func_call'
272 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:17:17: note: in expansion of macro 'dev_dbg'
17 | dev_dbg((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
| ^~~~~~~
drivers/firmware/imx/ele_mu.h:36:9: note: in expansion of macro 'miscdev_dbg'
36 | miscdev_dbg(&((p_devctx)->miscdev), fmt, ##va_args)
| ^~~~~~~~~~~
drivers/firmware/imx/ele_mu.c:437:17: note: in expansion of macro 'devctx_dbg'
437 | devctx_dbg(dev_ctx, "User buffer too small (%ld < %d)\n",
| ^~~~~~~~~~
drivers/firmware/imx/ele_mu.c:408:23: warning: variable 'header' set but not used [-Wunused-but-set-variable]
408 | struct mu_hdr header;
| ^~~~~~
drivers/firmware/imx/ele_mu.c:404:29: warning: unused variable 'ele_mu_priv' [-Wunused-variable]
404 | struct ele_mu_priv *ele_mu_priv = dev_ctx->priv;
| ^~~~~~~~~~~
vim +17 drivers/firmware/imx/ele_mu.h
12
13 /* macro to log operation of a misc device */
14 #define miscdev_dbg(p_miscdev, fmt, va_args...) \
15 ({ \
16 struct miscdevice *_p_miscdev = p_miscdev; \
> 17 dev_dbg((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
18 ##va_args); \
19 })
20
21 #define miscdev_info(p_miscdev, fmt, va_args...) \
22 ({ \
23 struct miscdevice *_p_miscdev = p_miscdev; \
24 dev_info((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
25 ##va_args); \
26 })
27
28 #define miscdev_err(p_miscdev, fmt, va_args...) \
29 ({ \
30 struct miscdevice *_p_miscdev = p_miscdev; \
> 31 dev_err((_p_miscdev)->parent, "%s: " fmt, (_p_miscdev)->name, \
32 ##va_args); \
33 })
34 /* macro to log operation of a device context */
35 #define devctx_dbg(p_devctx, fmt, va_args...) \
36 miscdev_dbg(&((p_devctx)->miscdev), fmt, ##va_args)
37 #define devctx_info(p_devctx, fmt, va_args...) \
38 miscdev_info(&((p_devctx)->miscdev), fmt, ##va_args)
39 #define devctx_err(p_devctx, fmt, va_args...) \
40 miscdev_err((&(p_devctx)->miscdev), fmt, ##va_args)
41
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists