linux-kernel - Re: [PATCH] BINDER:Allow tracing of binder_txn_latency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Apr 2023 08:45:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chuang Zhang <zhangchuang1909@...il.com>
Cc:     arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        joel@...lfernandes.org, brauner@...nel.org, cmllamas@...gle.com,
        surenb@...gle.com, linux-kernel@...r.kernel.org,
        zhangchuang3 <zhangchuang3@...omi.com>
Subject: Re: [PATCH] BINDER:Allow tracing of binder_txn_latency_free

On Wed, Apr 12, 2023 at 11:33:32AM +0800, Chuang Zhang wrote:
> From: zhangchuang3 <zhangchuang3@...omi.com>
> 
> The author forgot to EXPORT and need Export
> binder_txn_latency_free trace point.
> 
> Signed-off-by: zhangchuang3 <zhangchuang3@...omi.com>

I doubt you sign documents as "zhangchuang3", please always just use
your name, not your email alias.

And as this is coming from a gmail account, I can't ferify that this
really is an xiaomi.com address, why not just use your company address?

> ---
>  drivers/android/binder.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index fb56bfc45096..320cf08805d4 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6604,5 +6604,6 @@ device_initcall(binder_init);
>  
>  #define CREATE_TRACE_POINTS
>  #include "binder_trace.h"
> +EXPORT_TRACEPOINT_SYMBOL_GPL(binder_txn_latency_free);

What in-kernel code needs this?

thanks,

greg k-h