linux-kernel - Re: [PATCH v2 0/2] Fix test_resume failure by openning swap device non-exclusively

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDYF0xjpz7+b/Rmj@chenyu5-mobl1>
Date:   Wed, 12 Apr 2023 09:13:55 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     Pavan Kondeti <quic_pkondeti@...cinc.com>
CC:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <len.brown@...el.com>, Ye Bin <yebin10@...wei.com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] Fix test_resume failure by openning swap device
 non-exclusively

On 2023-04-11 at 11:00:50 +0530, Pavan Kondeti wrote:
> On Tue, Apr 11, 2023 at 08:18:43PM +0800, Chen Yu wrote:
> > test_resume does not work in current kernel when using swapfile for hibernation.
> > This is because the swap device should be openned non-exclusively in test_resume mode.
> > 
> > Patch 1 is a preparation for patch 2 and it turns snapshot_test into a global variable.
> > Patch 2 opens swap device non-exclusively for test_resume mode, and exclusively for manual
> > hibernation resume.
> > 
> > Change since v1:
> > Turn snapshot_test into global variable and do not introduce parameters for swsusp_check()
> > nor load_image_and_restore().
> > 
> > 
> > Chen Yu (2):
> >   PM: hibernate: Turn snapshot_test into global variable
> >   PM: hibernate: Do not get block device exclusively in test_resume mode
> > 
> >  kernel/power/hibernate.c | 12 +++++++++---
> >  kernel/power/power.h     |  1 +
> >  kernel/power/swap.c      |  5 +++--
> >  3 files changed, 13 insertions(+), 5 deletions(-)
> > 
> Looks good to me.
> 
> I have verified test_resume on QEMU arm64 and it worked fine with
> these two patches included.
>
Thanks, can I add your Tested-by tag?

thanks,
Chenyu 
> Thanks,
> Pavan