linux-kernel - Re: [PATCH v2 1/2] dt-bindings: leds: ROHM BD2606MVV LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Apr 2023 09:09:28 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     pavel@....cz, lee@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matti Vaittinen <mazziesaccount@...il.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: ROHM BD2606MVV LED driver

On 11/04/2023 21:30, Andreas Kemnade wrote:
> On Mon, 10 Apr 2023 17:34:00 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> [...]
>>> +        led-controller@66 {
>>> +            compatible = "rohm,bd2606mvv";
>>> +            #address-cells = <1>;
>>> +            #size-cells = <0>;
>>> +            reg = <0x66>;  
>>
>> reg is always second property in DTS.
>>
>>> +
>>> +            led@0 {
>>> +                color = <LED_COLOR_ID_RED>;
>>> +                function = LED_FUNCTION_POWER;
>>> +                reg = <0x0>;  
>>
>> Ditto
>>
> hmm, reg also second if no compatible first? I see it usually first in
> such cases.

Right, then reg is first.

Best regards,
Krzysztof