linux-kernel - RE: [PATCH 11/17] iommu/vt-d: Fix operand size in bitwise operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6ab9a30960d41c9b42e5880b89277e3@AcuMS.aculab.com>
Date:   Wed, 12 Apr 2023 07:11:24 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Baolu Lu' <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>
CC:     Vinod Koul <vkoul@...nel.org>, Tina Zhang <tina.zhang@...el.com>,
        "Jacob Pan" <jacob.jun.pan@...ux.intel.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 11/17] iommu/vt-d: Fix operand size in bitwise operation

From: Baolu Lu
> Sent: 12 April 2023 02:32
> 
> On 4/12/23 5:22 AM, David Laight wrote:
> >> Sent: 11 April 2023 07:48
> >>
> >> From: Tina Zhang<tina.zhang@...el.com>
> >>
> >> The patch fixes the klocwork issues that operands in a bitwise operation
> >> have different size at line 1692 of dmar.c, line 1898 and line 1907 of
> >> iommu.c.
> > Why is this any kind of thing that needs fixing?
> 
> This description is a bit misleading. Actually I queued it as a cleanup
> patch.

Hopefully without 'fix' anywhere in the description.
Otherwise the scripts will pick it for a back-port.

> > -		val |= (1 << 11) | 1;
> > +		val |= BIT_ULL(11) | BIT_ULL(0);

More problematic it what is bit 11 anyway?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)