linux-kernel - Re: [PATCH net-next] net/bridge: add drop reasons for bridge forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Apr 2023 18:49:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     xu xin <xu.xin.sc@...il.com>
Cc:     bridge@...ts.linux-foundation.org, davem@...emloft.net,
        edumazet@...gle.com, jiang.xuexin@....com.cn,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        pabeni@...hat.com, roopa@...dia.com, yang.yang29@....com.cn,
        zhang.yunkai@....com.cn, xu.xin16@....com.cn, razor@...ckwall.org
Subject: Re: [PATCH net-next] net/bridge: add drop reasons for bridge
 forwarding

On Wed, 12 Apr 2023 09:33:10 +0800 xu xin wrote:
> >You can return the reason from this function. That's the whole point of
> >SKB_NOT_DROPPED_YET existing and being equal to 0.
> 
> If returning the reasons, then the funtion will have to be renamed because
> 'should_deliever()' is expected to return a non-zero value  when it's ok to
> deliever. I don't want to change the name here, and it's better to keep its
> name and use the pointer to store the reasons.

Sure. You have to touch all callers, anyway, you can as well adjust 
the name.